opensensemap/opensensmapR
1
0
Fork 0
mirror of https://github.com/sensebox/opensensmapr synced 2025-02-20 20:23:58 +01:00
Code Issues Releases Wiki Activity

fix osem_as_measurements

Browse source
This commit is contained in:
noerw 2018-06-07 00:04:50 +02:00
parent 97768e7cdb
commit 994f08ab94
3 changed files with 11 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
DESCRIPTION
View file

@ -13,6 +13,7 @@ Suggests:
maps,
maptools,
readr,
tibble,
rgeos,
sf,
knitr,

4
R/measurement_utils.R
View file

@ -17,8 +17,8 @@ print.osem_measurements = function (x, ...) {
#' @param x A data.frame to attach the class to
#' @export
osem_as_measurements = function(x) {
ret = as.data.frame(x)
class(ret) = c('osem_measurements', class(x))
ret = tibble::as.tibble(x)
class(ret) = c('osem_measurements', class(ret))
ret
}

14
tests/testthat/test_measurements.R
View file

@ -8,8 +8,9 @@ try({
test_that('measurements can be retrieved for a phenomenon', {
check_api()
measurements = osem_measurements('Windgeschwindigkeit')
measurements = osem_measurements(x = 'Windgeschwindigkeit')
expect_true(is.data.frame(measurements))
expect_true(tibble::is.tibble(measurements))
expect_true('osem_measurements' %in% class(measurements))
})
@ -30,11 +31,6 @@ test_that('a response with no matching senseBoxes gives an error', {
expect_error(osem_measurements(x = 'Windgeschwindigkeit', exposure = 'indoor'), 'No senseBoxes found')
})
test_that('data.frame can be converted to measurements data.frame', {
df = osem_as_measurements(data.frame(c(1, 2), c('a', 'b')))
expect_equal(class(df), c('osem_measurements', 'data.frame'))
})
test_that('columns can be specified for phenomena', {
check_api()
@ -126,6 +122,12 @@ test_that('[.osem_measurements maintains attributes', {
expect_true(all(attributes(m[1:nrow(m), ]) %in% attributes(m)))
})
test_that('data.frame can be converted to measurements data.frame', {
m = osem_measurements('Windrichtung')
df = osem_as_measurements(data.frame(c(1, 2), c('a', 'b')))
expect_equal(class(df), class(m))
})
test_that('requests can be cached', {
check_api()