From 0ce3d3471b3c83b48157ff3aa424a2facf454f0c Mon Sep 17 00:00:00 2001
From: Norwin Roosen <github@nroo.de>
Date: Sun, 17 Feb 2019 14:02:23 +0100
Subject: [PATCH] make AboutPage i18n ready (#1)

---
 src/assets/i18n/en.json         | 12 ++++++++++-
 src/pages/about/about.html      | 37 +++++++++------------------------
 src/pages/about/about.module.ts |  2 ++
 src/pages/about/about.scss      |  3 +++
 4 files changed, 26 insertions(+), 28 deletions(-)

diff --git a/src/assets/i18n/en.json b/src/assets/i18n/en.json
index 2177d6a..59038f3 100644
--- a/src/assets/i18n/en.json
+++ b/src/assets/i18n/en.json
@@ -5,7 +5,17 @@
     "BLOCKLY": "Blockly"
   },
   "ABOUT": {
-    "TITLE": "About"
+    "TITLE": "About",
+    "BLOCKLY": {
+      "TITLE": "Blockly",
+      "TEXT1": "<em>Blockly for senseBox</em> is a visual programming editor for the <a href=\"https://sensebox.de/en/\">senseBox:edu</a>. It is based on Google's Blockly and Carlos Pereira Atencio's Ardublockly, which has been forked.",
+      "TEXT2": "Integrated support for over-the-air programming was developed at <a href=\"https://ifgi.de/en/\">ifgi</a> in a study project."
+    },
+    "OPENSOURCE": {
+      "TITLE": "Open Source",
+      "TEXT": "This app is free & libre open source software. To may find the source code & issue tracker on GitHub:"
+    },
+    "HINT": "<em>Hint:</em> A <a href=\"https://blockly.sensebox.de\">web version of Blockly for senseBox</a> is available as well!"
   },
   "BLOCKLY": {
     "TITLE": "Blockly for senseBox"
diff --git a/src/pages/about/about.html b/src/pages/about/about.html
index 465f062..8c3d654 100644
--- a/src/pages/about/about.html
+++ b/src/pages/about/about.html
@@ -1,9 +1,3 @@
-<!--
-  Generated template for the AboutPage page.
-
-  See http://ionicframework.com/docs/components/#navigation for more info on
-  Ionic pages and navigation.
--->
 <ion-header>
   <ion-navbar>
     <button ion-button menuToggle>
@@ -16,33 +10,26 @@
 <ion-content padding>
   <ion-grid>
     <ion-row>
-      <ion-col col-12 col-md-6>
+      <ion-col col-md-1></ion-col>
+      <ion-col col-12 col-md-5>
         <ion-card>
           <ion-card-header>
-            <ion-card-title>Blockly</ion-card-title>
+            <ion-card-title>{{ 'ABOUT.BLOCKLY.TITLE' | translate }}</ion-card-title>
           </ion-card-header>
           <ion-card-content>
-            <p>
-              <em>Blockly for senseBox</em> is a visual programming editor for the <a href="https://sensebox.de/en/">senseBox:edu</a>.
-              It is based on Google's Blockly and Carlos Pereira Atencio's Ardublockly, which has been forked.
-            </p>
-            <p>
-              Integrated support for over-the-air programming was developed at <a href="https://ifgi.de/en/">ifgi</a> in a study project.
-            </p>
+            <p [innerHTML]="'ABOUT.BLOCKLY.TEXT1' | translate"></p>
+            <p [innerHTML]="'ABOUT.BLOCKLY.TEXT2' | translate"></p>
           </ion-card-content>
         </ion-card>
       </ion-col>
 
-      <ion-col col-12 col-md-6>
+      <ion-col col-12 col-md-5>
         <ion-card>
           <ion-card-header>
-            <ion-card-title>Open Source</ion-card-title>
+            <ion-card-title>{{ 'ABOUT.OPENSOURCE.TITLE' | translate }}</ion-card-title>
           </ion-card-header>
           <ion-card-content>
-            <p>
-              This app is free & libre open source software.
-              To may find the source code & issue tracker on GitHub:
-            </p>
+            <p translate>ABOUT.OPENSOURCE.TEXT</p>
             <ul>
               <li><a href="https://github.com/sensebox/blockly-app">Source Code</a></li>
               <li><a href="https://github.com/sensebox/blockly-app/issues">Issue Tracker</a></li>
@@ -55,12 +42,8 @@
     </ion-row>
 
     <ion-row align-items-center>
-      <ion-col col-2></ion-col>
-      <ion-col colcol-8>
-        <p>
-          <em>Hint:</em>
-          A <a href="https://blockly.sensebox.de">web version of Blockly for senseBox</a> is available as well!
-        </p>
+      <ion-col>
+        <p class="hint" [innerHTML]="'ABOUT.HINT' | translate"></p>
       </ion-col>
     </ion-row>
   </ion-grid>
diff --git a/src/pages/about/about.module.ts b/src/pages/about/about.module.ts
index f180630..5a5b904 100644
--- a/src/pages/about/about.module.ts
+++ b/src/pages/about/about.module.ts
@@ -1,5 +1,6 @@
 import { NgModule } from '@angular/core';
 import { IonicPageModule } from 'ionic-angular';
+import { TranslateModule } from '@ngx-translate/core';
 import { AboutPage } from './about';
 
 @NgModule({
@@ -7,6 +8,7 @@ import { AboutPage } from './about';
     AboutPage,
   ],
   imports: [
+    TranslateModule,
     IonicPageModule.forChild(AboutPage),
   ],
 })
diff --git a/src/pages/about/about.scss b/src/pages/about/about.scss
index e69de29..201c659 100644
--- a/src/pages/about/about.scss
+++ b/src/pages/about/about.scss
@@ -0,0 +1,3 @@
+.hint {
+  text-align: center;
+}