1
0
Fork 0
mirror of https://gitea.com/gitea/tea.git synced 2026-04-11 04:28:35 +02:00
tea/modules/task
Nicolas f538c05282 refactor: code cleanup across codebase (#947)
## Summary

- Extract duplicate \`getReleaseByTag\` into shared \`cmd/releases/utils.go\`
- Replace \`log.Fatal\` calls with proper error returns in config and login commands; \`GetLoginByToken\`/\`GetLoginsByHost\`/\`GetLoginByHost\` now return errors
- Remove dead \`portChan\` channel in \`modules/auth/oauth.go\`
- Fix YAML integer detection to use \`strconv.ParseInt\` (correctly handles negatives and large ints)
- Fix \`path.go\` error handling to use \`errors.As\` + \`syscall.ENOTDIR\` instead of string comparison
- Extract repeated credential helper key into local variable in \`SetupHelper\`
- Use existing \`isRemoteDeleted()\` in \`pull_clean.go\` instead of duplicating the logic
- Fix ~30 error message casing violations to follow Go conventions
- Use \`fmt.Errorf\` consistently instead of string concatenation in \`generic.go\`

Reviewed-on: https://gitea.com/gitea/tea/pulls/947
Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com>
Reviewed-by: Bo-Yi Wu (吳柏毅) <appleboy.tw@gmail.com>
Co-authored-by: Nicolas <bircni@icloud.com>
Co-committed-by: Nicolas <bircni@icloud.com>
2026-04-08 03:38:49 +00:00
..
issue_create.go refactor: code cleanup across codebase (#947) 2026-04-08 03:38:49 +00:00
issue_edit.go feat(pulls): add edit subcommand for pull requests (#944) 2026-04-05 05:35:15 +00:00
labels.go feat(pulls): add edit subcommand for pull requests (#944) 2026-04-05 05:35:15 +00:00
labels_export.go spdx (#581) 2023-09-08 01:40:02 +00:00
login_create.go refactor: code cleanup across codebase (#947) 2026-04-08 03:38:49 +00:00
login_create_test.go Skip token uniqueness check when using SSH authentication (#898) 2026-02-19 15:19:45 +00:00
login_httpsign.go spdx (#581) 2023-09-08 01:40:02 +00:00
login_ssh.go spdx (#581) 2023-09-08 01:40:02 +00:00
milestone_create.go refactor: code cleanup across codebase (#947) 2026-04-08 03:38:49 +00:00
pull_checkout.go feat: store OAuth tokens in OS keyring via credstore (#926) 2026-03-12 02:49:14 +00:00
pull_clean.go refactor: code cleanup across codebase (#947) 2026-04-08 03:38:49 +00:00
pull_create.go feat: store OAuth tokens in OS keyring via credstore (#926) 2026-03-12 02:49:14 +00:00
pull_create_test.go spdx (#581) 2023-09-08 01:40:02 +00:00
pull_edit.go feat(pulls): add edit subcommand for pull requests (#944) 2026-04-05 05:35:15 +00:00
pull_merge.go refactor: code cleanup across codebase (#947) 2026-04-08 03:38:49 +00:00
pull_review.go spdx (#581) 2023-09-08 01:40:02 +00:00
pull_review_comment.go feat(pulls): add resolve, unresolve and review-comments subcommands (#948) 2026-04-08 03:36:09 +00:00
repo_clone.go feat: store OAuth tokens in OS keyring via credstore (#926) 2026-03-12 02:49:14 +00:00