mirror of
https://gitea.com/gitea/tea.git
synced 2026-01-29 18:25:19 +01:00
7ab3366220
## Summary
Fix the `tea labels delete` and `tea labels update` commands which were silently ignoring the `--id` flag.
## Problem
Both commands used `IntFlag` for the `--id` parameter but called `ctx.Int64("id")` to retrieve the value. This type mismatch caused the ID to always be read as `0`, making the commands useless.
**Before (bug):**
```bash
$ tea labels delete --id 36 --debug
DELETE: .../labels/0 # Wrong! ID ignored
```
**After (fix):**
```bash
$ tea labels delete --id 36 --debug
GET: .../labels/36 # Verify exists
DELETE: .../labels/36 # Correct ID
Label 'my-label' (id: 36) deleted successfully
```
## Changes
### labels/delete.go
- Change `IntFlag` to `Int64Flag` to match `ctx.Int64()` usage
- Make `--id` flag required
- Verify label exists before attempting deletion
- Provide clear error messages with label name and ID context
- Print success message after deletion
### labels/update.go
- Change `IntFlag` to `Int64Flag` to fix the same bug
## Test plan
- [x] `go test ./...` passes
- [x] `go vet ./...` passes
- [x] `gofmt` check passes
- [x] Manual testing confirms ID is now correctly passed to API
- [ ] CI passes
Reviewed-on: https://gitea.com/gitea/tea/pulls/865
Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: Alain Thiffault <athiffau@effectivemomentum.com>
Co-committed-by: Alain Thiffault <athiffau@effectivemomentum.com>
|
||
|---|---|---|
| .. | ||
| actions | ||
| admin/users | ||
| attachments | ||
| branches | ||
| flags | ||
| issues | ||
| labels | ||
| login | ||
| milestones | ||
| notifications | ||
| organizations | ||
| pulls | ||
| releases | ||
| repos | ||
| times | ||
| webhooks | ||
| actions.go | ||
| admin.go | ||
| attachments.go | ||
| branches.go | ||
| categories.go | ||
| clone.go | ||
| cmd.go | ||
| comment.go | ||
| issues.go | ||
| issues_test.go | ||
| labels.go | ||
| login.go | ||
| logout.go | ||
| man.go | ||
| milestones.go | ||
| notifications.go | ||
| open.go | ||
| organizations.go | ||
| pulls.go | ||
| releases.go | ||
| repos.go | ||
| times.go | ||
| webhooks.go | ||
| whoami.go | ||