mirror of
https://git.sr.ht/~rjarry/aerc
synced 2025-02-23 07:53:59 +01:00
73dc39c6ee
Add a new models.UID type (an alias to string). Replace all occurrences of uint32 being used as message UID or thread UID with models.UID. Update all workers to only expose models.UID values and deal with the conversion internally. Only IMAP needs to convert these to uint32. All other backends already use plain strings as message identifiers, in which case no conversion is even needed. The directory tree implementation needed to be heavily refactored in order to accommodate thread UID not being usable as a list index. Signed-off-by: Robin Jarry <robin@jarry.cc> Tested-by: Inwit <inwit@sindominio.net> Tested-by: Tim Culverhouse <tim@timculverhouse.com>
140 lines
2.8 KiB
Go
140 lines
2.8 KiB
Go
package marker_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"git.sr.ht/~rjarry/aerc/lib/marker"
|
|
"git.sr.ht/~rjarry/aerc/models"
|
|
)
|
|
|
|
// mockUidProvider implements the UidProvider interface and mocks the message
|
|
// store for testing
|
|
type mockUidProvider struct {
|
|
uids []models.UID
|
|
idx int
|
|
}
|
|
|
|
func (mock *mockUidProvider) Uids() []models.UID {
|
|
return mock.uids
|
|
}
|
|
|
|
func (mock *mockUidProvider) SelectedIndex() int {
|
|
return mock.idx
|
|
}
|
|
|
|
func createMarker() (marker.Marker, *mockUidProvider) {
|
|
uidProvider := &mockUidProvider{
|
|
uids: []models.UID{"1", "2", "3", "4"},
|
|
idx: 1,
|
|
}
|
|
m := marker.New(uidProvider)
|
|
return m, uidProvider
|
|
}
|
|
|
|
func TestMarker_MarkUnmark(t *testing.T) {
|
|
m, _ := createMarker()
|
|
uid := models.UID("4")
|
|
|
|
m.Mark(uid)
|
|
if !m.IsMarked(uid) {
|
|
t.Errorf("Marking failed")
|
|
}
|
|
|
|
m.Unmark(uid)
|
|
if m.IsMarked(uid) {
|
|
t.Errorf("Unmarking failed")
|
|
}
|
|
}
|
|
|
|
func TestMarker_ToggleMark(t *testing.T) {
|
|
m, _ := createMarker()
|
|
uid := models.UID("4")
|
|
|
|
if m.IsMarked(uid) {
|
|
t.Errorf("ToggleMark: uid should not be marked")
|
|
}
|
|
|
|
m.ToggleMark(uid)
|
|
if !m.IsMarked(uid) {
|
|
t.Errorf("ToggleMark: uid should be marked")
|
|
}
|
|
|
|
m.ToggleMark(uid)
|
|
if m.IsMarked(uid) {
|
|
t.Errorf("ToggleMark: uid should not be marked")
|
|
}
|
|
}
|
|
|
|
func TestMarker_Marked(t *testing.T) {
|
|
m, _ := createMarker()
|
|
expected := map[models.UID]struct{}{
|
|
"1": {},
|
|
"4": {},
|
|
}
|
|
for uid := range expected {
|
|
m.Mark(uid)
|
|
}
|
|
|
|
got := m.Marked()
|
|
if len(expected) != len(got) {
|
|
t.Errorf("Marked: expected len of %d but got %d", len(expected), len(got))
|
|
}
|
|
|
|
for _, uid := range got {
|
|
if _, ok := expected[uid]; !ok {
|
|
t.Errorf("Marked: received uid %q as marked but it should not be", uid)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestMarker_VisualMode(t *testing.T) {
|
|
m, up := createMarker()
|
|
|
|
// activate visual mode
|
|
m.ToggleVisualMark(false)
|
|
|
|
// marking should now fail silently because we're in visual mode
|
|
m.Mark("1")
|
|
if m.IsMarked("1") {
|
|
t.Errorf("marking in visual mode should not work")
|
|
}
|
|
|
|
// move selection index to last item
|
|
up.idx = len(up.uids) - 1
|
|
m.UpdateVisualMark()
|
|
expectedMarked := []models.UID{"2", "3", "4"}
|
|
|
|
for _, uidMarked := range expectedMarked {
|
|
if !m.IsMarked(uidMarked) {
|
|
t.Logf("expected: %#v, got: %#v", expectedMarked, m.Marked())
|
|
t.Errorf("updatevisual: uid %v should be marked in visual mode", uidMarked)
|
|
}
|
|
}
|
|
|
|
// clear all
|
|
m.ClearVisualMark()
|
|
if len(m.Marked()) > 0 {
|
|
t.Errorf("no uids should be marked after clearing visual mark")
|
|
}
|
|
|
|
// test remark
|
|
m.Remark()
|
|
for _, uidMarked := range expectedMarked {
|
|
if !m.IsMarked(uidMarked) {
|
|
t.Errorf("remark: uid %v should be marked in visual mode", uidMarked)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestMarker_MarkOutOfBound(t *testing.T) {
|
|
m, _ := createMarker()
|
|
|
|
outOfBoundUid := models.UID("100")
|
|
|
|
m.Mark(outOfBoundUid)
|
|
for _, markedUid := range m.Marked() {
|
|
if markedUid == outOfBoundUid {
|
|
t.Errorf("out-of-bound uid should not be marked")
|
|
}
|
|
}
|
|
}
|